Add cross-platform debugger detection implementation #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a platform-level utility to detect whether a debugger is attached by adding Debugger.swift. This implements a package-scoped isDebuggerAttached Bool computed at initialization that calls sysctl(3) to query the current process (KERN_PROC_PID) and checks the P_TRACED flag. The change logs an error via os_log if sysctl fails and returns false in that case. This fixes crashes related to missing debugger-detection logic and enables tests that depend on safe debugger-state handling.
Wrap Darwin imports and the kinfo_proc-based debugger check in #if canImport(Darwin) so Linux builds (which lack kinfo_proc, CTL_KERN, KERN_PROC, etc.) no longer fail to compile. Provide a fallback constant (isDebuggerAttached = false) for non-Darwin platforms.
Add a Linux-specific implementation to detect if the current process is being debugged by reading /proc/self/status and checking the TracerPid field. This was needed because the previous default returned false on non-Apple platforms; the new code parses the status file and returns true when TracerPid is non-zero to correctly detect attached debuggers on Linux.
Add a unit test (DebuggerTests.testIsDebuggerAttachedIsFalse) that asserts isDebuggerAttached == false. This verifies the Debugger utility returns false in the test environment and prevents regressions. The change also cleans up conditional import placement in Debugger.swift to ensure compilation on Darwin platforms.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
==========================================
+ Coverage 24.38% 24.45% +0.07%
==========================================
Files 483 484 +1
Lines 27893 27921 +28
==========================================
+ Hits 6802 6829 +27
- Misses 21091 21092 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation Details
Darwin (macOS/iOS)
sysctl()system call withKERN_PROC_PIDto get process informationP_TRACEDflag inkp_proc.p_flagto detect debugger attachmentos_logfor failed system callsLinux
/proc/self/statusfile to get process status informationTracerPidfield - non-zero value indicates debugger attachmentCross-platform Support
#if canImport(Darwin)for platform-specific codepackage let isDebuggerAttached: BoolTest Coverage
DebuggerTests.swiftwith test case ensuringisDebuggerAttached == falseduring normal executionCompatibility